Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layer memory crash #876

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Fix layer memory crash #876

merged 3 commits into from
Apr 29, 2022

Commits on Apr 28, 2022

  1. WIP to find the memory bug involved in OpenChemistry#824 

    Right now, this reverts OpenChemistry#806 but there's still some sort
of memory corruption when assigning one molecule to another

Also, it seems like File -> Import Crystal adds atoms that
don't have layer information

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
    @ghutchis
    ghutchis committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b088d23 View commit details
    Browse the repository at this point in the history

  2. Make sure when copy / assign molecules that all atoms are 

    added to the active layer.

An ideal thing might be to create a new temporary layer
(e.g., a copy layer) but this is a good step

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
    @ghutchis
    ghutchis committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    165305f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into find-layer-memory-bug

    @ghutchis
    ghutchis authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6223ee7 View commit details
    Browse the repository at this point in the history