Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new layer from selection #899

Merged
merged 5 commits into from
May 28, 2022

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented May 22, 2022

Draft to create a new layer from a selection (e.g., select a bunch of water molecules, hide them)

  • Creates a new layer
  • Sets the render types in the new layer to the same set from the active layer
  • Moves the selected atoms into the new layer

Still needs:

  • Update menu list after creating the new layer
  • Send a signal to update the LayerModel UI

This should probably move the code from selectiontool.cpp into the RWLayerManager for "cloneNewLayer()` or something similar.

It might also be worth just adding this to the default RWLayerManager addLayer() method to reduce surprise (e.g., create a new layer that defaults to the same render types as the active layer).

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

ghutchis added 2 commits May 17, 2022 13:33
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis linked an issue May 22, 2022 that may be closed by this pull request
@ghutchis ghutchis added the enhancement feature changes / API changes label May 22, 2022
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis
Copy link
Member Author

This needs more testing .. and probably cloning the settings?

@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@avo-bot
Copy link

avo-bot commented May 27, 2022

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/may-2022-development-progress/3836/1

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis changed the title WIP: Create new layer from selection Create new layer from selection May 27, 2022
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Ubuntu-2004.tar.gz
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis merged commit 0413546 into OpenChemistry:master May 28, 2022
@ghutchis ghutchis deleted the create-layer-selection branch May 28, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature changes / API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Layer from Selection
2 participants