Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oc_titler bugfix #991

Merged
merged 6 commits into from
Sep 20, 2023
Merged

oc_titler bugfix #991

merged 6 commits into from
Sep 20, 2023

Conversation

Medea-Destiny
Copy link
Collaborator

Zero length titles in chat command (i.e [prefix] title) was returning "title" as a title, rather than opening the textbox as intended.

dependabot bot and others added 6 commits December 8, 2022 04:27
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.13.10.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.9...v1.13.10)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…okogiri-1.13.10

Bump nokogiri from 1.13.9 to 1.13.10 in /docs
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.10 to 1.15.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.13.10...v1.15.3)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…okogiri-1.15.3

Bump nokogiri from 1.13.10 to 1.15.3 in /docs
0 length titles via chat commands (i.e [prefix]title) were returning "title" as a title rather than opening the textbox as intended.
@Medea-Destiny Medea-Destiny changed the title Medea destiny patch 3 oc_titler bugfix Sep 11, 2023
@NikkiLacrima NikkiLacrima self-requested a review September 14, 2023 14:53
@NikkiLacrima
Copy link
Contributor

Code looks good, tested and works as intended.

Copy link
Contributor

@NikkiLacrima NikkiLacrima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested with no issues

@SilkieSabra SilkieSabra merged commit 05c3518 into 8.3_Features-branch Sep 20, 2023
2 checks passed
@SilkieSabra SilkieSabra deleted the Medea-Destiny-patch-3 branch September 20, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants