Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current port rather than hardcoding 8080 #20

Merged
merged 1 commit into from
May 11, 2017

Conversation

mattsheppard
Copy link

I initially wanted to use @LocalServerPort like AbstractIntegrationTest
does, but got execeptions from Spring. This approach is based
on http://stackoverflow.com/a/36391145/797

Fixes #19

I initially wanted to use @LocalServerPort like AbstractIntegrationTest
does, but got execeptions from Spring. This approach is based
on http://stackoverflow.com/a/36391145/797

Fixes OpenConext#19
@codecov-io
Copy link

Codecov Report

Merging #20 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
+ Coverage     93.83%   93.84%   +0.01%     
  Complexity      130      130              
============================================
  Files            24       24              
  Lines           454      455       +1     
  Branches          5        5              
============================================
+ Hits            426      427       +1     
  Misses           25       25              
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...p/src/main/java/mujina/idp/MetadataController.java 100% <100%> (ø) 3 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b5003...65b1edb. Read the comment docs.

@oharsta oharsta self-assigned this May 11, 2017
@oharsta oharsta merged commit 64a9539 into OpenConext:master May 11, 2017
v1-evansb added a commit to bazzani/Mujina that referenced this pull request Mar 7, 2018
…91-ecs-ephemeral-port-support

LM-1291: SAML - Mock IdP ECS ephemeral port support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants