Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the NameID Format via attributes. #46

Merged
merged 1 commit into from
Aug 17, 2018

Conversation

Villane
Copy link

@Villane Villane commented Jun 27, 2018

I want to code my SP to accept only certain NameID formats, thus I need to be able to change it for the mock identity provider. I thought the simplest way to do it might be via setting an attribute.

@codecov-io
Copy link

Codecov Report

Merging #46 into master will decrease coverage by 0.55%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage        95%   94.44%   -0.56%     
- Complexity      142      143       +1     
============================================
  Files            25       25              
  Lines           480      486       +6     
  Branches          5        7       +2     
============================================
+ Hits            456      459       +3     
- Misses           21       23       +2     
- Partials          3        4       +1
Impacted Files Coverage Δ Complexity Δ
...na-idp/src/main/java/mujina/idp/SsoController.java 87.87% <57.14%> (-8.42%) 11 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff652a...540e98e. Read the comment docs.

@oharsta oharsta merged commit 540e98e into OpenConext:master Aug 17, 2018
oharsta added a commit that referenced this pull request Aug 17, 2018
Changed the for-loop to functional style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants