Do not send SubjectConfirmationData Address= with URL #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, Mujina would send the following SubjectConfirmationData: ```xml <saml2:SubjectConfirmationData Address="https://engine.example.org/authentication/sp/consume-assertion" ``` The Address attribute is in SAML 2.0 core more or less defined to be an IP-address (or at least something a session can be "bound" to). This being an URL trips some very strict libraries. IP-address binding is not a feature that is useful in Mujina (or in general, if you ask me). Likely best just not to send it at all.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 92.48% 92.48%
Complexity 153 153
=========================================
Files 29 29
Lines 532 532
Branches 10 10
=========================================
Hits 492 492
Misses 30 30
Partials 10 10Continue to review full report at Codecov.
|
thijskh
deleted the
bugfix/subjectconfirmationdata-invalid-address-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, Mujina would send the following SubjectConfirmationData:
The Address attribute is in SAML 2.0 core more or less defined to be
an IP-address (or at least something a session can be "bound" to).
This being an URL trips some very strict libraries.
IP-address binding is not a feature that is useful in Mujina (or in
general, if you ask me). Likely best just not to send it at all.