Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify the contact person on a role when it is created through the API #338

Closed
steinwelberg opened this issue Dec 19, 2024 · 6 comments
Milestone

Comments

@steinwelberg
Copy link

Currently the contact person for roles created through an API key are always the person that owns the API key. This leads to situations where a the owner of the API key gets contacted for expired invites while they don't know anything about the role as they do not even have to be the role manager.

This is currently happening for the roles created for the SURF Developer Platform.

@oharsta
Copy link
Member

oharsta commented Dec 20, 2024

@steinwelberg Do you use the endpoint /api/external/v1/roles using an Organisation API key or the endpoint /api/external/v1/internal/invite/roles using basic authentication? And which attribute of a role do you refer to, when you write contact person for roles?

It is true that if you use the second endpoint the attribute remoteApiUser is automatically set to the userName of the basic authentication. You do however have the ability to specify an inviterDisplayName, which is a free format field that is used in the invitation emails for this role. Does that suffice?

@steinwelberg
Copy link
Author

steinwelberg commented Dec 20, 2024

We are using the first endpoint with an Org API key. Can we do the same with this endpoint?

@oharsta
Copy link
Member

oharsta commented Dec 20, 2024

Yes. You can specify both the inviterDisplayName and remoteApiUser and those values from the POST body will be used. Does that suffice? The Invited by column in the GUI will still show the name of the user who owns the API key. This is more difficult to change, because an invitation created with Organisation API key requires an inviter_id which is a foreign key to the users table.

@steinwelberg
Copy link
Author

I take it the end-user receiving the invitation will only see the values from the inviterDisplayName and remoteApiUser, right? If that is the case then this suffices for us indeed.

@oharsta
Copy link
Member

oharsta commented Dec 20, 2024

The end-user will see the inviterDisplayName in the invitation email and when the user accepts the invitation. The remoteApiUser is not used in the communication with the end-user.

@oharsta
Copy link
Member

oharsta commented Dec 23, 2024

Closed as current functionality suffices.

@oharsta oharsta closed this as completed Dec 23, 2024
@github-project-automation github-project-automation bot moved this from New to Delivered in Openconext-Invite Dec 23, 2024
@thijskh thijskh closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
@oharsta oharsta added this to the 0.0.25 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Delivered
Development

No branches or pull requests

3 participants