Option to add ribbon to engineblock pages indication which environmen… #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this solution. And TIL: you can safely use attr in :before and :after pseudoselectors. Caniuse first confused me in that aspect. But after reading on, the widespread support for attr() in content selectors lifted my concerns. See: https://caniuse.com/?search=css%20attr() What might be a good addition to this PR:
|
thijskh
force-pushed
the
feature/env-specific-ribbon
branch
from
8045f06 to
93e727a
Compare
…t you're working on When left empty, nothing is shown. The approach may look a bit unwieldy, but this is done so that envirnment specific config can be passed to CSS. This is making it a pure CSS solution that also would work in installs that have a CSP that disables inline styles, that's why we have to enumerate the available colors since you cannot use `attr()` with anything other than `content:`.
thijskh
force-pushed
the
feature/env-specific-ribbon
branch
from
93e727a to
cdb012c
Compare
Also make the codes match the actual HTML color names for simplicity.
|
I have documented such in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t you're working on
When left empty, nothing is shown.
The approach may look a bit unwieldy, but this is done so that envirnment specific config can be passed to CSS. This is making it a pure CSS solution that also would work in installs that have a CSP that disables inline styles, that's why we have to enumerate the available colors since you cannot use
attr()with anything other thancontent:.