Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update saml2 library to 4.6.13 #1341

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Update saml2 library to 4.6.13 #1341

merged 3 commits into from
Nov 26, 2024

Conversation

baszoetekouw
Copy link
Member

No description provided.

@baszoetekouw baszoetekouw requested a review from pmeulen November 22, 2024 13:46
@baszoetekouw baszoetekouw marked this pull request as draft November 22, 2024 13:51
@baszoetekouw
Copy link
Member Author

Behat tests are failing; investigating if this is fixable.

@tvdijen
Copy link
Contributor

tvdijen commented Nov 22, 2024 •
edited
Loading

I see this assertion being hit in the log (line 1273):
simplesamlphp/saml2@b4daf21

The signed message doesn't contain a Destination

@baszoetekouw baszoetekouw marked this pull request as ready for review November 23, 2024 14:58
@baszoetekouw baszoetekouw requested a review from tvdijen November 23, 2024 14:59
@baszoetekouw
Copy link
Member Author

OK, miscommited 1 line. Will fix when I get home.

tvdijen
tvdijen approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@tvdijen tvdijen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense given the error that we had hit.
The assertion was added in v4.6 of the library to better enforce the SAML 2.0 core specifications.

@tvdijen tvdijen requested a review from thijskh November 23, 2024 17:23
@baszoetekouw
Fix integration test
f119094 
The Mock IdP must set a Destination attribute in the <Response>, as per simplesamlphp/saml2@b4daf21
@baszoetekouw baszoetekouw merged commit 8259e53 into main Nov 26, 2024
2 checks passed
@baszoetekouw baszoetekouw deleted the feature/saml2-upgrade branch November 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdijen tvdijen tvdijen approved these changes

@pmeulen pmeulen Awaiting requested review from pmeulen

@thijskh thijskh Awaiting requested review from thijskh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baszoetekouw @tvdijen