Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker configs #111

Merged
merged 15 commits into from
Mar 12, 2024
Merged

Feature/docker configs #111

merged 15 commits into from
Mar 12, 2024

Conversation

danakim
Copy link
Contributor

@danakim danakim commented Nov 14, 2023

Hi @quartje ! This is the initial version of the PR. Like we discussed, you will need to add the configs to the Docker image. The paths are:

For Apache2: add it in /etc/apache2/sites-enabled/
For Shibboleth: overwrite the file /etc/shibboleth/shibboleth2.xml

@danakim danakim requested a review from quartje November 14, 2023 13:22
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (9fa732e) to head (d242851).
Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     83.04%   83.06%   +0.01%     
- Complexity     1042     1043       +1     
============================================
  Files           102      102              
  Lines          3221     3224       +3     
  Branches        319      319              
============================================
+ Hits           2675     2678       +3     
  Misses          368      368              
  Partials        178      178              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@quartje quartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with teams: We'd like to introduce the snapshot build process. I will create a ticket for that

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@quartje quartje force-pushed the feature/docker_configs branch from b99d4de to 36aa36f Compare November 18, 2023 10:15
Copy link
Contributor Author

@danakim danakim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@quartje quartje force-pushed the feature/docker_configs branch from 5b633d6 to ad6bef7 Compare February 21, 2024 08:48
quartje added 2 commits March 11, 2024 12:04
Add an override file that can be used when using the docker compose
setup. It is used when the app is started with --spring.profiles.active=docker
@quartje quartje force-pushed the feature/docker_configs branch from 343fa10 to 3830950 Compare March 11, 2024 11:04
@quartje quartje requested a review from oharsta March 11, 2024 11:07
@quartje quartje merged commit 2589bd3 into master Mar 12, 2024
2 checks passed
@quartje quartje deleted the feature/docker_configs branch March 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants