Stop using SurfConextId in the AA client #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/further-remove-surfconext-id
branch
from
dbe449e to
49ec79f
Compare
thijskh
approved these changes
Apr 30, 2019
MKodde
force-pushed
the
feature/further-remove-surfconext-id
branch
from
49ec79f to
e0d6fb2
Compare
The AA client still used the dropped SurfConextId attribute, resulting in the aa client being unable to find any results. As that attribute no longer was received by profile, as EB stopped releasing it. The solution is, again, to use the NameId value instead. Some renaming on the AA client response objects was performed to make sure that, semantically makes more sense. Finally some remaining translation entries have been cleaned up too. See: https://www.pivotaltracker.com/story/show/164103691/comments/202141482
MKodde
force-pushed
the
feature/further-remove-surfconext-id
branch
from
e0d6fb2 to
3367d22
Compare
MKodde
force-pushed
the
feature/further-remove-surfconext-id
branch
from
1731801 to
8a58623
Compare
pablothedude
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AA client still used the dropped SurfConextId attribute, resulting
in the aa client being unable to find any results. As that attribute no
longer was received by profile, as EB stopped releasing it.
The solution is, again, to use the NameId value instead. Some renaming
on the AA client response objects was performed to make sure that,
semantically makes more sense.
Finally some remaining translation entries have been cleaned up too.
See:
https://www.pivotaltracker.com/story/show/164103691/comments/202141482