Address security issues #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MDL package was tracked in the project. Probably in order to simply upgrade to newer version. A better solution would be to start using NPM for these kind of dependencies. This is something for the icebox. By removing the MDL package, the security wanring from Github is silenced. This was a warning on a dev dependency of the MDL library.
MKodde
force-pushed
the
feature/mdl-security-upgrade
branch
from
46e7a3a to
7c5632b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github warns us about the use of a vulnerable jQuery version in the MDL package.json. This is a not used/installed package.json. And as a solution, I chose to remove the entire mdl folder from the project and simply add the two minified assets to the js/css folders instead.
More important was a way older jquery version we are actually using in the project. That version of jQuery is upgraded to the latest.
I've added a story to the Pivotal backlog to introduce npm in order to track the installed frontend packages. This will improve security drastically.