Update ORCiD ID styling on the my connections page #128
Conversation
To closer match the proposed button design in: https://members.orcid.org/api/resources/graphics#use-button
Other than that, the link id has been made into an anchor. As requested in: https://members.orcid.org/api/resources/graphics#display-ids
The Dutch and English texts have been updated. The Portuguese text has remained unchanged.
| @@ -24,11 +24,11 @@ | |||
| <div class="mdl-grid"> | |||
| <div class="mdl-cell mdl-cell--3-col"> | |||
| <div class="mdl-layout-title">{{ 'profile.my_connections.service_label'|trans }}</div> | |||
| <img src="{{ connection.logoPath }}" title="{{ 'profile.my_connections.orcid.title'|trans }}"/> | |||
| <img src="{{ connection.logoPath }}" class="logo" title="{{ 'profile.my_connections.orcid.title'|trans }}"/> | |||
There was a problem hiding this comment.
This may be out of the scope for this PR, but these images don't have an alt text. Adding them may benefit users who use a screen reader, and make it clear what should be there if the image doesn't load
There was a problem hiding this comment.
Yes, a good suggestion. Fixed that for the connect/disconnect logo.
| @@ -246,7 +246,9 @@ This profile page gives you insight in which personal data, provided by your ins | |||
| </trans-unit> | |||
| <trans-unit id="c4b69512880a8532d9740e870ed8a60b8791b3bc" resname="profile.my_connections.orcid.description"> | |||
| <source>profile.my_connections.orcid.description</source> | |||
| <target>ORCID is a nonproprietary alphanumeric code to uniquely identify scientific and other academic authors. This addresses the problem that a particular author's contributions to the scientific literature or publications in the humanities can be hard to recognize as most personal names are not unique, they can change (such as with marriage), have cultural differences in name order, contain inconsistent use of first-name abbreviations and employ different writing systems.</target> | |||
| <target>Connect your existing or newly created ORCID iD to SURFconext once. The ORCID iD is a code that is used to uniquely identify scientific and other academic authors. | |||
There was a problem hiding this comment.
Is it intended to be iD in this text (small i big D)?
There was a problem hiding this comment.
Well spotted, copypasta from a text provided by a PM. But will update this!
| @@ -246,7 +246,9 @@ This profile page gives you insight in which personal data, provided by your ins | |||
| </trans-unit> | |||
| <trans-unit id="c4b69512880a8532d9740e870ed8a60b8791b3bc" resname="profile.my_connections.orcid.description"> | |||
| <source>profile.my_connections.orcid.description</source> | |||
| <target>ORCID is a nonproprietary alphanumeric code to uniquely identify scientific and other academic authors. This addresses the problem that a particular author's contributions to the scientific literature or publications in the humanities can be hard to recognize as most personal names are not unique, they can change (such as with marriage), have cultural differences in name order, contain inconsistent use of first-name abbreviations and employ different writing systems.</target> | |||
| <target>Connect your existing or newly created ORCID iD to SURFconext once. The ORCID iD is a code that is used to uniquely identify scientific and other academic authors. | |||
There was a problem hiding this comment.
@domgon we updated the ORCID iD pre-connection text. We managed to update our Dutch and English translations but did not even attempt a Portuguese update. Would you be so kind as to submit an improved version of this text? If you do not see any improvements whatsoever, we are fine with that too of course!
There was a problem hiding this comment.
Hi @MKodde !
<target>Ligue o seu ORCID ID existente ou recém-criado ao serviço SURFconext. O ORCID ID é um código que é usado para identificar de forma única autores científicos e outros autores académicos.</target>
Is this what you where asking? I made the translation of the new sentence.
There was a problem hiding this comment.
Thanks @domgon Yes that is the first part of the sentence. The entire translation was changed. To be more specific: the 'source' identified by: profile.my_connections.orcid.description was changed. And you translated the first part only. Sorry for not being more clear in the first place :)
For more details see the story in Pivotal. But most relevant information regarding the changes can be found on the individual commit messages.