-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ORCiD button placement for all devices #136
Conversation
As reported on: https://www.pivotaltracker.com/story/show/167167954 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Two feedback points:
- The connected connections will still be rendered in the three-column layout. I don't think that's correct. During my previous changes to this feature, I usually stuffed the connections template variables with a couple of connected and available connections. Even though the 'disconnect' button would probably fit on the third column without issue. I think, from a UX perspective it's best to place interactable buttons on a predictable position. I'm also curious why the buttons are placed above the logo and text. Isn't the point to first inform yourself about the service your connecting to, and then clicking the button. But if PM's are happy so am I :) Just curious.
- On smaller screens, the text-overflow on the buttons is still an issue. Not something that's easily fixed. But good to discuss with the PM's nonetheless.
I did already test the
Good catch, I've shrunk the button text on small view ports. |
The login button doesn't fit on small screens even if they aren't that small. Now the button is placed above the connection so it will fit.
ecf4a2b
to
86f9a18
Compare
Re 1: LTR is better, roger that. But starting a form with a call to action, without informing what you are clicking might not be terribly user friendly? I'm by no means a UX guru, but this raised a smell alarm with me. Also I still think both form variants should look similar. Re 2: 👍 |
Consulted the PO with this UX choice but haven't heard anything bavk yet. It wasn't shocking enough though to prevent building a release so I'll do nothing with this until a new story is filed. |
The login button doesn't fit on small screens even if they aren't that
small. Now the button is placed above the connection so it will fit.