Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ORCiD button placement for all devices #136

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

pablothedude
Copy link
Contributor

The login button doesn't fit on small screens even if they aren't that
small. Now the button is placed above the connection so it will fit.

@MKodde
Copy link
Member

MKodde commented Sep 5, 2019

Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Two feedback points:

  1. The connected connections will still be rendered in the three-column layout. I don't think that's correct. During my previous changes to this feature, I usually stuffed the connections template variables with a couple of connected and available connections. Even though the 'disconnect' button would probably fit on the third column without issue. I think, from a UX perspective it's best to place interactable buttons on a predictable position. I'm also curious why the buttons are placed above the logo and text. Isn't the point to first inform yourself about the service your connecting to, and then clicking the button. But if PM's are happy so am I :) Just curious.
  2. On smaller screens, the text-overflow on the buttons is still an issue. Not something that's easily fixed. But good to discuss with the PM's nonetheless.

@MKodde
Copy link
Member

MKodde commented Sep 5, 2019

Screenshot_2019-09-05 My Connections — SURFconext Profile

@MKodde MKodde changed the title Fix orcid button padding Optimize ORCiD button placement for all devices Sep 5, 2019
@pablothedude
Copy link
Contributor Author

1. The connected connections will still be rendered in the three-column layout. I don't think that's correct. During my previous changes to this feature, I usually stuffed the connections template variables with a couple of connected and available connections. Even though the 'disconnect' button would probably fit on the third column without issue. I think, from a UX perspective it's best to place interactable buttons on a predictable position. I'm also curious why the buttons are placed above the logo and text. Isn't the point to first inform yourself about the service your connecting to, and then clicking the button. But if PM's are happy so am I :) Just curious.

I did already test the active connections and found the four columns acceptable because the content is not the same. Because it was a requirement to keep the full text on the button it was the best option to put the button above the text also from an UX point of view it's good to place the buttons on the top left because you also read LTR.

2. On smaller screens, the text-overflow on the buttons is still an issue. Not something that's easily fixed. But good to discuss with the PM's nonetheless.

Good catch, I've shrunk the button text on small view ports.

The login button doesn't fit on small screens even if they aren't that
small. Now the button is placed above the connection so it will fit.
@pablothedude pablothedude force-pushed the feature/fix-orcid-login-button branch from ecf4a2b to 86f9a18 Compare September 5, 2019 12:04
@MKodde
Copy link
Member

MKodde commented Sep 9, 2019

Re 1: LTR is better, roger that. But starting a form with a call to action, without informing what you are clicking might not be terribly user friendly? I'm by no means a UX guru, but this raised a smell alarm with me. Also I still think both form variants should look similar.

Re 2: 👍

@MKodde MKodde self-requested a review September 9, 2019 06:17
@pablothedude
Copy link
Contributor Author

Consulted the PO with this UX choice but haven't heard anything bavk yet. It wasn't shocking enough though to prevent building a release so I'll do nothing with this until a new story is filed.

@pablothedude pablothedude merged commit c8b6922 into develop Sep 16, 2019
@pablothedude pablothedude deleted the feature/fix-orcid-login-button branch September 16, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants