Ensure givenName is not required for using Profile #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having the GivenName in the released attribute set would halt profile in the IntroductionController. Effectively showing an error right after logging in to Profile. This chane makes the use of the givenName attrib optional. An additional change might be required ot make the UX more fluent as the header element is now only stating 'Hi !' when logging in. One step at a time! https://www.pivotaltracker.com/story/show/179882084
Badlapje
suggested changes
Oct 12, 2021
| @@ -9,8 +9,11 @@ | |||
| {% endblock %} | |||
|
|
|||
| {% block content %} | |||
| {% if userName != false %} | |||
There was a problem hiding this comment.
This can probably be shortened to if userName
For PT I've left the current setup where we have the welcome to the profile page text. For NL I updated the title according to the suggestion provided by Arnout.
MKodde
force-pushed
the
bugfix/givenName-not-required
branch
from
801d162 to
28b41c2
Compare
|
The security warning is fixed in one of the other PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having the GivenName in the released attribute set would halt
profile in the IntroductionController. Effectively showing an error
right after logging in to Profile.
This chane makes the use of the givenName attrib optional. An additional
change might be required ot make the UX more fluent as the header
element is now only stating 'Hi !' when logging in.
One step at a time!
https://www.pivotaltracker.com/story/show/179882084