Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log which user authenticated to the application. #229

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Mar 1, 2022

Previously we've reduced the loglevel of a number of events to info level,
but an actual login action deserves to stand out at notice level. We
add the username of the authenticated user so that if anything goes wrong
or is reported, we can find out who it was.

Before:

Mar  1 12:07:20 t06.ams.surfconext.nl openconext-profile[26631]: app.INFO: Authentication succeeded, redirecting to original location [] []

After:

Mar  1 12:28:15 t06.ams.surfconext.nl openconext-profile[30817]: app.NOTICE: Authentication succeeded, redirecting to original location {"user":"urn:collab:person:surfnet.nl:kinkhorst"} []

@thijskh thijskh requested a review from MKodde March 1, 2022 11:18
Previously we've reduced the loglevel of a number of events to info level,
but an actual login action deserves to stand out at notice level. We
add the username of the authenticated user so that if anything goes wrong
or is reported, we can find out who it was.
@thijskh thijskh force-pushed the logging/log-authenticated-user branch from de0e6cc to d89e1c8 Compare March 1, 2022 11:29
@MKodde MKodde merged commit 8f747f3 into develop Apr 13, 2022
@thijskh thijskh deleted the logging/log-authenticated-user branch April 13, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants