Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonFormatter #284

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Add JsonFormatter #284

merged 1 commit into from
Apr 25, 2024

Conversation

parijke
Copy link
Contributor

@parijke parijke commented Apr 25, 2024 •
edited
Loading

Add a JsonFormatter to the project and use it in monolog

@parijke parijke force-pushed the feature/json-formatter branch 2 times, most recently from 9294c8d to ac7dfae Compare April 25, 2024 08:54
@parijke parijke force-pushed the feature/json-formatter branch from ac7dfae to be001ca Compare April 25, 2024 08:56
@parijke parijke requested review from quartje and MKodde April 25, 2024 08:58
MKodde
MKodde reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fit the bill.

Question: why not composer require surfnet/stepup-bundle and use this class from there?

@parijke parijke merged commit 1f62d13 into main Apr 25, 2024
1 check passed
@parijke parijke deleted the feature/json-formatter branch April 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKodde MKodde MKodde approved these changes

@quartje quartje Awaiting requested review from quartje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parijke @MKodde