Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Invite roles overview page #294

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Add the Invite roles overview page #294

merged 8 commits into from
Aug 21, 2024

Conversation

MKodde
Copy link
Member

@MKodde MKodde commented Aug 15, 2024 •
edited by thijskh
Loading

Performed tasks

  • Retrieve the Roles for the logged in user from the Invite API
  • Display the Roles
  • Set missing icon
  • Defaults have been set, but translations could be improved upon

MKodde added 2 commits August 15, 2024 14:37
@MKodde
Add and describe the feature flag in config
8d722b5
@MKodde
Create /invite-roles route and restrict access
808b56a 
Only allow access to this route when the feature flag is enabled
@MKodde MKodde linked an issue Aug 15, 2024 that may be closed by this pull request
Show roles from OpenConext Invite #293
Closed
@MKodde MKodde marked this pull request as draft August 15, 2024 14:04
@MKodde MKodde force-pushed the feature/invite-roles branch from b9002cd to e3aaf9c Compare August 20, 2024 07:07
MKodde added 3 commits August 20, 2024 09:12
@MKodde
Turn the API response into ValueObjects
5a90d9d
@MKodde
Display the InviteRole data in the template
ec5b5a5 
Some tweaking was required to get all the required data into the twig
template
@MKodde
Update code to meet QA standards
31de457 
The stan baseline was updated to allow a couple of high effort, low gain
issues (mainly type hinting based)
@MKodde MKodde force-pushed the feature/invite-roles branch from e3aaf9c to 31de457 Compare August 20, 2024 08:25
@MKodde MKodde marked this pull request as ready for review August 20, 2024 08:29
@MKodde MKodde requested review from parijke and thijskh August 20, 2024 08:30
@thijskh
Copy link
Member

thijskh commented Aug 20, 2024

The menu item can use this icon: https://www.streamlinehq.com/icons/phosphor-light?search=users&icon=ico_4RsU5MV0aCVVeiCJ

MKodde and others added 2 commits August 21, 2024 09:52
@MKodde
Improve the roles logo
de7ab8e 
It now shows a group of person thingies like this:

               @@@@@       @@@@@
              @@@@@@@     @@@@@@@
             @@@   @@     @@   @@@
             @@    @@     @@    @@
             @@       @@@       @@
              @@    @@@@@@@    @@
              @@@@ @@@@ @@@@ @@@@
             @@@@@ @@     @@ @@@@@
            @@@    @@     @@    @@@
            @@     @@     @@     @@
                   @@     @@
                   @@@   @@@
                    @@@@@@@
                   @@@@@@@@@
                  @@@@   @@@@
                 @@@       @@@
                 @@         @@
@thijskh
Update translations for invite
48c3478
@MKodde MKodde merged commit ca31411 into main Aug 21, 2024
1 check passed
@MKodde MKodde deleted the feature/invite-roles branch August 21, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijskh thijskh thijskh approved these changes

@parijke parijke Awaiting requested review from parijke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show roles from OpenConext Invite
2 participants
@MKodde @thijskh