Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spacing in inviteRoles__top to avoid overlap #297

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

oharsta
Copy link
Member

@oharsta oharsta commented Aug 28, 2024

No description provided.

@MKodde
Copy link
Member

MKodde commented Aug 28, 2024

Thanks for adding the gap @oharsta, This helps, but does not completely solve the overlap (at least not as I observed it). I still had to set a max-width and added an overflow-hidden on the img container

And ensure there is no visual overflow
@MKodde MKodde force-pushed the bugfix/invite-logo-overlap branch from 0cdd22b to 8f27c37 Compare August 29, 2024 05:53
Take 2

The max witdh of the contianer combined with the overflow hidden already
caused the image from no longer overlap the text. That was fixed in the
previous commit. But the logo would still be displayed partially. As the
width of the logo was not restricted. The max width is now inherited
from the container <div>.
@MKodde MKodde force-pushed the bugfix/invite-logo-overlap branch from f0ef8f0 to c4822f9 Compare September 2, 2024 14:18
@MKodde MKodde merged commit 82c5cc8 into main Sep 4, 2024
4 checks passed
@MKodde MKodde deleted the bugfix/invite-logo-overlap branch September 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants