Repair the SelfVet ACS Controller

The controller was not autoconfigurable fixed that by adding a service definition. And the MW client bundle command: SelfVetSecondFactorCommand was not configured correctly. A none existant field was set on it. Repaired that This actally fixed two PHPStan issues :hurray:
OpenConext · May 22, 2024 · 3beac96 · 3beac96
1 parent 715f928
commit 3beac96
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/ci/qa/phpstan-baseline.php b/ci/qa/phpstan-baseline.php
@@ -546,11 +546,6 @@
 	'count' => 2,
 	'path' => __DIR__ . '/../../src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/SelfVet/SelfVetConsumeController.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Parameter \\#2 \\.\\.\\.\\$values of function sprintf expects bool\\|float\\|int\\|string\\|null, Surfnet\\\\StepupSelfService\\\\SelfServiceBundle\\\\Value\\\\SelfVetRequestId given\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/../../src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/SelfVet/SelfVetConsumeController.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Property Surfnet\\\\StepupSelfService\\\\SelfServiceBundle\\\\Command\\\\SelfVetCommand\\:\\:\\$authoringLoa \\(string\\) does not accept string\\|null\\.$#',
 	'count' => 1,
@@ -886,11 +881,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/../../src/Surfnet/StepupSelfService/SelfServiceBundle/Service/RaLocationService.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Access to an undefined property Surfnet\\\\StepupMiddlewareClientBundle\\\\Identity\\\\Command\\\\SelfVetSecondFactorCommand\\:\\:\\$authoringSecondFactorLoa\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/../../src/Surfnet/StepupSelfService/SelfServiceBundle/Service/SecondFactorService.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Cannot call method getElements\\(\\) on Surfnet\\\\StepupMiddlewareClientBundle\\\\Identity\\\\Dto\\\\UnverifiedSecondFactorCollection\\|Surfnet\\\\StepupMiddlewareClientBundle\\\\Identity\\\\Dto\\\\VerifiedSecondFactorCollection\\|Surfnet\\\\StepupMiddlewareClientBundle\\\\Identity\\\\Dto\\\\VettedSecondFactorCollection\\|null\\.$#',
 	'count' => 2,

diff --git a/...rfnet/StepupSelfService/SelfServiceBundle/Controller/SelfVet/SelfVetConsumeController.php b/...rfnet/StepupSelfService/SelfServiceBundle/Controller/SelfVet/SelfVetConsumeController.php
@@ -97,7 +97,7 @@ public function consumeSelfVetAssertion(Request $httpRequest, string $secondFact
                 $samlLogger->error(
                     sprintf(
                         'Expected a response to the request with ID "%s", but the SAMLResponse was a response to a different request',
-                        $initiatedRequestId
+                        $initiatedRequestId->requestId()
                     )
                 );
                 throw new AuthenticationException('Unexpected InResponseTo in SAMLResponse');

diff --git a/src/Surfnet/StepupSelfService/SelfServiceBundle/Resources/config/services.yaml b/src/Surfnet/StepupSelfService/SelfServiceBundle/Resources/config/services.yaml
@@ -30,10 +30,21 @@ services:
             - '@surfnet_saml.http.redirect_binding'
             - '@surfnet_saml.http.post_binding'
             - '@surfnet_saml.hosted.service_provider'
-            - '@self_service.second_factor_test_idp'
+            - '@surfnet_saml.remote.idp'
             - '@surfnet_saml.logger'
             - '@logger'
 
+    Surfnet\StepupSelfService\SelfServiceBundle\Controller\SelfVet\SelfVetConsumeController:
+        arguments:
+            - "@logger"
+            - "@surfnet_stepup_self_service_self_service.service.second_factor"
+            - "@self_service.service.self_vet_marshaller"
+            - "@surfnet_saml.hosted.service_provider"
+            - '@surfnet_saml.remote.idp'
+            - "@surfnet_saml.http.post_binding"
+            - "@surfnet_saml.logger"
+            - "@request_stack"
+
     surfnet_stepup_self_service_self_service.service.command:
         class: Surfnet\StepupSelfService\SelfServiceBundle\Service\CommandService
         arguments:

diff --git a/src/Surfnet/StepupSelfService/SelfServiceBundle/Service/SecondFactorService.php b/src/Surfnet/StepupSelfService/SelfServiceBundle/Service/SecondFactorService.php
@@ -84,7 +84,7 @@ public function selfVet(SelfVetCommand $command): bool
         $apiCommand->secondFactorId = $command->secondFactor->secondFactorIdentifier;
         $apiCommand->secondFactorType = $command->secondFactor->type;
         $apiCommand->authorityId = $command->identity->id;
-        $apiCommand->authoringSecondFactorLoa = $command->authoringLoa;
+        $apiCommand->authoringSecondFactorIdentifier = $command->authoringLoa;
 
         $result = $this->commandService->execute($apiCommand);
         return $result->isSuccessful();