Simplified logic and used named routes again

OpenConext · Dec 16, 2023 · 8fc916d · 8fc916d
1 parent 12bdf18
commit 8fc916d
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/EntryPointController.php b/src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/EntryPointController.php
@@ -42,17 +42,10 @@ public function decideSecondFactorFlow() : RedirectResponse
         $identity = $this->getIdentity();
         $hasSecondFactor = $this->secondFactorService->doSecondFactorsExistForIdentity($identity->id);
         $hasRecoveryToken = $this->recoveryTokenService->hasRecoveryToken($identity);
-        $current = '/';
-        if (!is_null($this->authStateHandler->getCurrentRequestUri())) {
-            $current = $this->authStateHandler->getCurrentRequestUri();
-        }
-        $this->activationFlowService->process($current);
-        if ($hasSecondFactor || $hasRecoveryToken) {
-            return $this->redirect($this->generateUrl('ss_second_factor_list'));
-        } else {
-            return $this->redirect(
-                $this->generateUrl('ss_registration_display_types')
-            );
-        }
+        $this->activationFlowService->process($this->authStateHandler->getCurrentRequestUri());
+
+        return $hasSecondFactor || $hasRecoveryToken
+            ? $this->redirectToRoute('ss_second_factor_list')
+            : $this->redirectToRoute('ss_registration_display_types');
     }
 }