Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing forward in polymorphic_allocator #41

Closed
thirtytwobits opened this issue Jun 20, 2023 · 0 comments
Closed

Missing forward in polymorphic_allocator #41

thirtytwobits opened this issue Jun 20, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@thirtytwobits
Copy link
Member

typename EnableIfNotPair<U>::return_type construct(U* p, Args&&... args) is not forwarding the args which leads to a loss of qualifiers for some operations. Simple fix but critical consequences as this bug means some types are copied instead of moved.
@thirtytwobits thirtytwobits added the bug Something isn't working label Jun 20, 2023
thirtytwobits added a commit that referenced this issue Jun 20, 2023
@thirtytwobits
fix for issue #41
952c1bb
thirtytwobits added a commit that referenced this issue Jun 21, 2023
@thirtytwobits
fix for issue #41 (#42)
ca2e505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thirtytwobits