Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v8] test: l2fwd_perf: add simpler l2 forwarding tester #2122

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

TuomasTaipale
Copy link
Collaborator

@TuomasTaipale TuomasTaipale commented Sep 23, 2024

odp_l2fwd_perf is a tester for benchmarking L2 throughput of a set of interfaces. Tester provides a more simplified fast path handling and configuration compared to the existing odp_l2fwd.

Aim is to keep the tester as simple as possible in order to provide a stable benchmarking utility with comparable results across releases.

Additionally, remove the slightly outdated odp_l2fwd_simple example and related files.

v4:

  • Matias' comments
  • Improved runner script's failure detection

v5:

  • Matias' comments

v6:

  • Matias' comments

v7:

  • Fixed an issue where workers ended up using same input/output queues in MT unsafe mode in some cases

v8:

  • Rebased
  • Added reviewed-by tags

@odpbuild odpbuild changed the title test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v1] test: l2fwd_perf: add simpler l2 forwarding tester Sep 23, 2024
example/l2fwd_simple/odp_l2fwd_simple.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v1] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v2] test: l2fwd_perf: add simpler l2 forwarding tester Sep 25, 2024
@odpbuild odpbuild changed the title [PATCH v2] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v3] test: l2fwd_perf: add simpler l2 forwarding tester Sep 25, 2024
@odpbuild odpbuild changed the title [PATCH v3] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v4] test: l2fwd_perf: add simpler l2 forwarding tester Sep 25, 2024
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v4] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v5] test: l2fwd_perf: add simpler l2 forwarding tester Oct 4, 2024
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
test/performance/odp_l2fwd_perf.c Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v5] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v6] test: l2fwd_perf: add simpler l2 forwarding tester Oct 8, 2024
@odpbuild odpbuild changed the title [PATCH v6] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v7] test: l2fwd_perf: add simpler l2 forwarding tester Oct 10, 2024
Remove the slightly outdated `odp_l2fwd_simple` example and related
files.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
`odp_l2fwd_perf` is a tester for benchmarking L2 throughput of a set of
interfaces. Tester provides a more simplified fast path handling and
configuration compared to the existing `odp_l2fwd`.

Aim is to keep the tester as simple as possible in order to provide a
stable benchmarking utility with comparable results across releases.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
Add script for setting up a test run of `odp_l2fwd_perf` during `make
check`. Script is heavily influenced by the existing `odp_l2fwd_run.sh`.

Signed-off-by: Tuomas Taipale <tuomas.taipale@nokia.com>
Reviewed-by: Matias Elo <matias.elo@nokia.com>
@odpbuild odpbuild changed the title [PATCH v7] test: l2fwd_perf: add simpler l2 forwarding tester [PATCH v8] test: l2fwd_perf: add simpler l2 forwarding tester Oct 10, 2024
@MatiasElo MatiasElo merged commit fd7b710 into OpenDataPlane:master Oct 10, 2024
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants