For records, check that ocids are unique, not whole records #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, for the case where ids/ocids are missing, we fallback to the message "Array has non-unique elements" This ensures we don't get a block of python repr data in the error message: OpenDataServices/cove#1220 There's also been a change of case from "Non-unique ID Values" to "Non-unique id values".
Bjwebb
force-pushed
the
1220-improve-non-unique-elements-error
branch
from
88a4053 to
4ef40e5
Compare
kindly
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, for the case where ids/ocids are missing, we fallback to the message "Array has non-unique elements"
This ensures we don't get a block of python repr data in the error message: OpenDataServices/cove#1220
There's also been a change of case from "Non-unique ID Values" to "Non-unique id values".