Skip to content

Update workflows#21

Merged
jerrysxie merged 7 commits intoOpenDevicePartnership:mainfrom
jerrysxie:remove-per-commit-checking
Dec 15, 2025
Merged

Update workflows#21
jerrysxie merged 7 commits intoOpenDevicePartnership:mainfrom
jerrysxie:remove-per-commit-checking

Conversation

@jerrysxie
Copy link
Contributor

@jerrysxie jerrysxie commented Dec 13, 2025

This pull request simplifies and streamlines the GitHub Actions workflow defined in .github/workflows/check.yml. The main focus is on removing the per-commit matrix strategy, consolidating job logic, and updating toolchain usage for consistency and maintainability. Additionally, a new test job is introduced to ensure tests and test code linting are always run.

Workflow simplification and removal of per-commit checks:

  • Removed the commit_list job and all related matrix strategies that previously ran checks on each commit individually, simplifying the workflow and reducing redundancy. [1] [2]
  • Updated all jobs (fmt, clippy, doc, features, deny, msrv) to run only on the latest code instead of iterating over each commit, and removed references to the commit matrix and associated checkout logic. [1] [2] [3] [4] [5] [6]

Job and toolchain updates:

  • Changed the clippy job to run only on the stable toolchain (removing beta), and replaced the clippy-action usage with a direct cargo clippy command for simplicity.
  • Updated the doc job to use the stable toolchain instead of nightly, aligning with the rest of the workflow.

Test coverage improvements:

  • Added a new test job that runs cargo test and subsequently checks for clippy warnings in test code, ensuring both runtime correctness and code quality in tests.

These changes make the CI workflow easier to maintain, faster to run, and more consistent across all jobs.

Copilot AI review requested due to automatic review settings December 13, 2025 01:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the per-commit checking mechanism from the GitHub Actions workflow, simplifying the CI pipeline to check only the HEAD commit instead of testing each commit in a PR individually.

Key Changes:

  • Removed the commit_list job that generated a list of commits to test
  • Removed matrix strategies based on commits from all jobs (fmt, clippy, doc, hack, deny, msrv)
  • Updated workflow comments to reflect the removal of per-commit checking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerrysxie jerrysxie self-assigned this Dec 13, 2025
@jerrysxie jerrysxie marked this pull request as ready for review December 13, 2025 02:39
@jerrysxie jerrysxie requested a review from a team as a code owner December 13, 2025 02:39
@jerrysxie jerrysxie enabled auto-merge December 13, 2025 02:40
@jerrysxie jerrysxie disabled auto-merge December 13, 2025 02:40
@jerrysxie jerrysxie enabled auto-merge December 13, 2025 02:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 13, 2025 03:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 13, 2025 03:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/check.yml:160

  • The MSRV job is supposed to check the minimum supported Rust version (1.85), but it's installing and using the stable toolchain instead. The toolchain should be set to the MSRV value from the matrix. Change toolchain: stable to toolchain: ${{ matrix.msrv }} and update the cargo command from cargo +stable check to cargo check to properly test against the specified MSRV.
      - name: Install stable
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: stable
      - name: cargo +stable check
        run: cargo check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 13, 2025 03:19
@jerrysxie jerrysxie force-pushed the remove-per-commit-checking branch from d75b81c to a932279 Compare December 13, 2025 03:19
@jerrysxie jerrysxie disabled auto-merge December 13, 2025 03:20
@jerrysxie jerrysxie changed the title workflows: remove per-commit checking Update workflow to latest ODP standards Dec 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.github/workflows/check.yml:175

  • The MSRV job is checking the Minimum Supported Rust Version but the toolchain installation specifies 'stable' instead of using the matrix MSRV value. The toolchain should be set to '${{ matrix.msrv }}' to properly validate that the crate can build with the minimum supported version (1.85).
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: stable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 13, 2025 03:23
@jerrysxie jerrysxie changed the title Update workflow to latest ODP standards Update workflows Dec 13, 2025
@jerrysxie jerrysxie force-pushed the remove-per-commit-checking branch from f3ac9b2 to 09f143a Compare December 13, 2025 03:26
@jerrysxie jerrysxie enabled auto-merge (squash) December 13, 2025 03:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

.github/workflows/check.yml:177

  • The msrv job should install the MSRV toolchain version from the matrix variable, not the stable toolchain. The toolchain should be set to '${{ matrix.msrv }}' instead of 'stable' to properly validate that the codebase builds with the minimum supported Rust version.
      - name: Install stable
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: stable
      - name: cargo +stable check
        run: cargo check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jerrysxie jerrysxie merged commit 5d924cf into OpenDevicePartnership:main Dec 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants