Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the per-commit checking mechanism from the GitHub Actions workflow, simplifying the CI pipeline to check only the HEAD commit instead of testing each commit in a PR individually.
Key Changes:
- Removed the
commit_listjob that generated a list of commits to test - Removed matrix strategies based on commits from all jobs (fmt, clippy, doc, hack, deny, msrv)
- Updated workflow comments to reflect the removal of per-commit checking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/check.yml:160
- The MSRV job is supposed to check the minimum supported Rust version (1.85), but it's installing and using the
stabletoolchain instead. The toolchain should be set to the MSRV value from the matrix. Changetoolchain: stabletotoolchain: ${{ matrix.msrv }}and update the cargo command fromcargo +stable checktocargo checkto properly test against the specified MSRV.
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
- name: cargo +stable check
run: cargo check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d75b81c to
a932279
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
.github/workflows/check.yml:175
- The MSRV job is checking the Minimum Supported Rust Version but the toolchain installation specifies 'stable' instead of using the matrix MSRV value. The toolchain should be set to '${{ matrix.msrv }}' to properly validate that the crate can build with the minimum supported version (1.85).
uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f3ac9b2 to
09f143a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
.github/workflows/check.yml:177
- The msrv job should install the MSRV toolchain version from the matrix variable, not the stable toolchain. The toolchain should be set to '${{ matrix.msrv }}' instead of 'stable' to properly validate that the codebase builds with the minimum supported Rust version.
- name: Install stable
uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
- name: cargo +stable check
run: cargo check
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request simplifies and streamlines the GitHub Actions workflow defined in
.github/workflows/check.yml. The main focus is on removing the per-commit matrix strategy, consolidating job logic, and updating toolchain usage for consistency and maintainability. Additionally, a new test job is introduced to ensure tests and test code linting are always run.Workflow simplification and removal of per-commit checks:
commit_listjob and all related matrix strategies that previously ran checks on each commit individually, simplifying the workflow and reducing redundancy. [1] [2]fmt,clippy,doc,features,deny,msrv) to run only on the latest code instead of iterating over each commit, and removed references to the commit matrix and associated checkout logic. [1] [2] [3] [4] [5] [6]Job and toolchain updates:
clippyjob to run only on the stable toolchain (removing beta), and replaced theclippy-actionusage with a directcargo clippycommand for simplicity.docjob to use the stable toolchain instead of nightly, aligning with the rest of the workflow.Test coverage improvements:
testjob that runscargo testand subsequently checks for clippy warnings in test code, ensuring both runtime correctness and code quality in tests.These changes make the CI workflow easier to maintain, faster to run, and more consistent across all jobs.