Add clippy allow to smart battery macro and uprev bitfield-struct#40
Merged
tullom merged 2 commits intoOpenDevicePartnership:mainfrom Jan 21, 2026
Conversation
kurtjd
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There exists an edge case where clippy will fail if the underlying driver's return error type
Result<(), T>is the same as the associated Error type, meaning that theOk(foo()?)pattern can be simplified tofoo(). The question mark does a conversion for us if the return type offoo()is different from the associated type, and we want this functionality always. Therefore, we allow the clippy lintclippy::needless_question_markUprev to v0.3.4