Add Debug derive for ACPI types#42
Merged
kurtjd merged 1 commit intoOpenDevicePartnership:mainfrom Feb 18, 2026
Merged
Conversation
kurtjd
requested review from
felipebalbi,
gjpmsft,
jerrysxie and
madeleyneVaca
kurtjd
force-pushed
the
acpi-derive-debug
branch
from
4c05689 to
1dd226f
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds Debug derive to all ACPI types in the embedded-batteries crate to improve ergonomics when using these types in std environments where defmt is not available. The change addresses issue #41 which requested Debug/Display trait derivations for types that previously only had defmt support.
Changes:
- Added
Debugto the derive list of all ACPI types (structs, enums, and newtypes) - Positioned
Debugas the first trait in all derive lists for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
williampMSFT
approved these changes
Feb 18, 2026
jerrysxie
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adds
Debugto the derive list for ACPI types for easy formatting whendefmtis not available.Resolves #41