Add SyncCell type to support Sync fix in embassy upstream #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHuard
force-pushed
the
jimi/sync-intrusive-list
branch
from
108160e to
1105e38
Compare
JamesHuard
requested review from
RobertZ2011,
asasine,
ayodejiige,
gjpmsft,
jerrysxie and
wmmc88
JamesHuard
force-pushed
the
jimi/sync-intrusive-list
branch
from
1105e38 to
caa059d
Compare
gjpmsft
previously approved these changes
Jun 20, 2025
asasine
reviewed
Jun 20, 2025
wmmc88
reviewed
Jun 20, 2025
wmmc88
reviewed
Jun 20, 2025
add where T:Send {} back
Co-authored-by: Melvin Wang <melvin.mc.wang@gmail.com>
asasine
approved these changes
Jun 23, 2025
wmmc88
approved these changes
Jun 23, 2025
gjpmsft
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embassy upstream recently fixed accidentally adding Sync to non-Sync types: embassy-rs/embassy#4320
In preparation to fix #361, added a drop-in replacement for Cell where moving to a proper primitive usage such as embassy_sync::mutex::Mutex is untenable. This also refactors the intrusive_list to utilize this new SyncCell type, allowing it to be used directly without any containers.
Note that in most cases SyncCell is not the best solution. If it is possible, proper synchronization primitives should be leveraged.
A critical section was used as opposed to a blocking_mutex type, as blocking_mutex is non-re-entrant. This allows the most flexibility in supporting scenarios with SyncCell, and does not require permutated get and set implementations based on mutex backing type.
In short: