Update dependencies and replace Cell and RefCell with SyncCell and Mutex, respectively #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo Vet Audit Passed
|
tullom
force-pushed
the
fix-embassy-sync-regressions
branch
2 times, most recently
from
bb315c4 to
a161f15
Compare
Contributor
Author
|
Looks like the CI failures are due to a circular dependency between |
jerrysxie
requested changes
Jun 25, 2025
JamesHuard
reviewed
Jun 25, 2025
JamesHuard
reviewed
Jun 25, 2025
JamesHuard
previously approved these changes
Jun 25, 2025
Contributor
JamesHuard
left a comment
JamesHuard
left a comment
There was a problem hiding this comment.
Awesome work @tullom! Did we happen to test this with embassy tip of main to see if it can build now?
tullom
force-pushed
the
fix-embassy-sync-regressions
branch
from
a161f15 to
a431ab7
Compare
Contributor
Author
Yes, this PR includes changes to |
JamesHuard
previously approved these changes
Jun 26, 2025
asasine
previously approved these changes
Jun 26, 2025
tullom
force-pushed
the
fix-embassy-sync-regressions
branch
from
5ceceae to
79da228
Compare
tullom
force-pushed
the
fix-embassy-sync-regressions
branch
from
79da228 to
4bfbf0a
Compare
tullom
force-pushed
the
fix-embassy-sync-regressions
branch
from
4bfbf0a to
7a6ed4f
Compare
jerrysxie
previously approved these changes
Jul 2, 2025
kurtjd
previously approved these changes
Jul 2, 2025
asasine
previously approved these changes
Jul 3, 2025
|
All of my comments are non-blocking. |
asasine
approved these changes
Jul 3, 2025
jerrysxie
approved these changes
Jul 3, 2025
kurtjd
pushed a commit
that referenced
this pull request
Jul 8, 2025
… and update examples (#386) Thank you to @magravel for fixing the changes in embedded-cfu-protocol. This PR includes the same .rs changes in #341. - Update cfu-service to use constructs in embedded-cfu-protocol v0.2.0 - Further testing showed that I missed some Cells in battery-service/device.rs that should've been fixed in #372 - Fixed in this PR - Update examples to be Sync safe and patch embedded-services to remove a circular dependency in the examples' `Cargo.toml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicPtr<T>rather than*mut [T]