power-policy-service: Depanic#634
Merged
RobertZ2011 merged 1 commit intoOpenDevicePartnership:mainfrom Dec 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes panic-prone code patterns from the power-policy-service by replacing .expect() and .unwrap() calls with proper error handling. The changes improve the service's robustness by gracefully handling initialization failures and option unwrapping instead of potentially panicking at runtime.
Key changes:
- Replaced
.expect()with proper None handling in PowerPolicy initialization - Refactored
.unwrap()usage by restructuring control flow to use if-let pattern for best_consumer
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| power-policy-service/src/lib.rs | Replaced .expect() on PowerPolicy::create with if-let pattern and early return on None |
| power-policy-service/src/consumer.rs | Replaced .unwrap() on best_consumer with if-let pattern, eliminating early return and simplifying control flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RobertZ2011
requested review from
asasine,
chchongmsft,
felipebalbi,
gjpmsft,
jerrysxie and
seanbrns
kurtjd
previously approved these changes
Dec 10, 2025
RobertZ2011
force-pushed
the
power-policy-depanic
branch
from
a05f842 to
8c250dc
Compare
RobertZ2011
force-pushed
the
power-policy-depanic
branch
from
8c250dc to
cb2102d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kurtjd
previously approved these changes
Dec 12, 2025
felipebalbi
previously approved these changes
Dec 12, 2025
RobertZ2011
dismissed stale reviews from asasine, felipebalbi, and kurtjd
via
0811e05
RobertZ2011
force-pushed
the
power-policy-depanic
branch
from
cb2102d to
0811e05
Compare
kurtjd
approved these changes
Dec 12, 2025
asasine
approved these changes
Dec 12, 2025
jerrysxie
pushed a commit
that referenced
this pull request
Dec 24, 2025
Removed panic paths from the `buffer` module. Instead made methods fallible and introduced an `Error` type. Because certain traits are used with methods that assume infallibility (such as the drop and borrow traits), I couldn't just make these return a result. Instead, I added a `Poisoned` status so in the off chance that a `drop` or `borrow` call would have panicked originally, the buffer is marked poisoned and will return a `Poisoned` error on future accesses. This also breaks the interfaces of a few services. For these I added a `Buffer` error and made methods fallible if necessary. I'm not a fan of this since any buffer errors represent an internal programming bug to the service and not something the user should expect/handle, and this breaks encapsulation. I do not want to silently just ignore buffer errors, so I'm not sure what other alternative there is here (open to suggestions). *Edit*: Thinking about maybe renaming the `Buffer` error variant of these services to `Internal` or something. I'd prefer to make it more clear when an error represents an internal invariant being broken that is not something meant to be handled by the caller in any practical manner. It would act as a catchall since the specifics of what caused the error are implementation details that could change any time and not something the caller should be concerned with. Also introduced a `Never` type alias which is useful now that some functions represent never-ending tasks which should never return unless there is an error (see related discussion: #634 (comment)). Resolves #659
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.