Skip to content

Refactor TplMutex #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joschock merged 4 commits into from
Nov 18, 2025
Merged

Refactor TplMutex #1056

joschock merged 4 commits into from
Nov 18, 2025

Conversation

@joschock
Copy link
Contributor

@joschock joschock commented Nov 13, 2025 •
edited
Loading

Description

Renames the tpl_lock.rs module to tpl_mutex and refactors the logic. Key improvements:

  • Remove the dependency on BootServices for TPL manipulation. TplMutex now directly calls the raise_tpl/restore_tpl APIs directly rather than through the BootServices table. This greatly simplifies the usage model and testing of TplMutex.

Also updates Synchronization chapter of the docbook.

This change pursuant to RFC 0021 #1036

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Boot testing on hardware platform.

Integration Instructions

N/A

@github-actions github-actions bot added impact:testing Affects testing type:documentation Improvements or additions to documentation labels Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
patina_dxe_core/src/protocol_db.rs 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@joschock joschock linked an issue Nov 13, 2025 that may be closed by this pull request
[Feature]: Removal of Atomics code in Patina #898
Closed
@joschock
Copy link
Contributor Author

joschock commented Nov 13, 2025

Reviewer note: to see just the functional refactor, that is broken out to a separate commit from the rename and doc updates in PR history.

@makubacki makubacki added the type:design-change A new proposal or modification to a feature design label Nov 14, 2025
cfernald
cfernald approved these changes Nov 17, 2025
View reviewed changes
@joschock joschock merged commit eb508ed into OpenDevicePartnership:main Nov 18, 2025
7 checks passed
@joschock joschock mentioned this pull request Dec 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfernald cfernald cfernald approved these changes

@makubacki makubacki makubacki approved these changes

@os-d os-d os-d approved these changes

@Javagedes Javagedes Awaiting requested review from Javagedes

Assignees

No one assigned

Labels

impact:testing Affects testing type:design-change A new proposal or modification to a feature design type:documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Removal of Atomics code in Patina

4 participants

@joschock @cfernald @makubacki @os-d