PE Image Load: Include image name on failure #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
vineelko
force-pushed
the
users/vineelko/pe_image_name_fix_1117
branch
from
078c4c5 to
6cc7e71
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Javagedes
reviewed
Nov 17, 2025
os-d
approved these changes
Nov 17, 2025
Javagedes
approved these changes
Nov 17, 2025
makubacki
reviewed
Nov 17, 2025
makubacki
approved these changes
Nov 17, 2025
vineelko
force-pushed
the
users/vineelko/pe_image_name_fix_1117
branch
2 times, most recently
from
5cdaeb5 to
9d7e9b7
Compare
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
vineelko
force-pushed
the
users/vineelko/pe_image_name_fix_1117
branch
from
9d7e9b7 to
6ec2c8f
Compare
vineelko
added a commit
to vineelko/patina
that referenced
this pull request
Nov 20, 2025
- The console logger was added to tests to improve code coverage for the `log::*` APIs in OpenDevicePartnership#1069. - However, the `patina_dxe_core` crate currently has a few tests (`uefi_memory_map`) that use their own logger for custom behavior. - Since both loggers end up in the same test binary (`patina_dxe_core-0fa2c65cbd247021.exe`), we cannot have two loggers in the same process (the `uefi_memory_map` logger initialization can panic if the console logger is already enabled). - Until we finalize a proper mechanism that supports both scenarios, this PR reverts the previously added console logger. Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
5 tasks
vineelko
added a commit
to vineelko/patina
that referenced
this pull request
Nov 21, 2025
- The console logger was added to tests to improve code coverage for the `log::*` APIs in OpenDevicePartnership#1069. - However, the `patina_dxe_core` crate currently has a few tests (`uefi_memory_map`) that use their own logger for custom behavior. - Since both loggers end up in the same test binary (`patina_dxe_core-0fa2c65cbd247021.exe`), we cannot have two loggers in the same process (the `uefi_memory_map` logger initialization can panic if the console logger is already enabled). - Until we finalize a proper mechanism that supports both scenarios, this PR reverts the previously added console logger. Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
vineelko
added a commit
that referenced
this pull request
Nov 21, 2025
## Description - The console logger was added to tests to improve code coverage for the `log::*` APIs in #1069. - However, the `patina_dxe_core` crate currently has a few tests (`uefi_memory_map`) that use their own logger for custom behavior. - Since both loggers end up in the same test binary (`patina_dxe_core-0fa2c65cbd247021.exe`), we cannot have two loggers in the same process (the `uefi_memory_map` logger initialization can panic if the console logger is already enabled). - Until we finalize a proper mechanism that supports both scenarios(code coverage + uefi_memory_map debug logs), this PR reverts the previously added console logger. === - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested `cargo make all` ## Integration Instructions NA Signed-off-by: Vineel Kovvuri[MSFT] <vineelko@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PE Image Load: Include image name on failure
How This Was Tested
Validated on Q35
Integration Instructions
NA