[patina_dxe_core] Safety comments for lib.rs #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
3 times, most recently
from
05039f5 to
79f5f5f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
os-d
reviewed
Nov 21, 2025
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
from
79f5f5f to
e56d9c4
Compare
5 tasks
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
from
e56d9c4 to
39b372e
Compare
makubacki
approved these changes
Nov 26, 2025
Collaborator
|
@Raymond-MS, the codecov patch check failure is related to your new code. Can you please try adding some tests to cover the code? 
|
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
2 times, most recently
from
1c32339 to
b5833e9
Compare
Javagedes
reviewed
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Javagedes
reviewed
Nov 26, 2025
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
from
b5833e9 to
b6f5c19
Compare
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
from
b6f5c19 to
4c3c71a
Compare
Javagedes
approved these changes
Dec 1, 2025
…ssary. Added test code for the updated function.
Raymond-MS
force-pushed
the
personal/rdiaz/SafetyComments
branch
from
4c3c71a to
bae0c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated lib.rs to include safety comments around unsafe blocks and added checks where necessary. Added test code for the updated function.
How This Was Tested
Built and ran with QEMU SBSA platform. Booted to UEFI shell successfully.
Integration Instructions
N/A