patina_dxe_core: Do not wrap set_hob_list in debug_assert
#1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
force-pushed
the
personal/joeyvagedes/stop-optimize
branch
from
9c8eb92 to
45a79d0
Compare
os-d
approved these changes
Nov 21, 2025
makubacki
approved these changes
Nov 21, 2025
The compiler, on release builds, was optimizing out the call_once call, so future calls to set_hob_list was panicking. This commit changes the debug_assert to an �ssert and changes the rue return from set_hob_list to be based off of the inner value of hob_list to hint to the compiler that the call_once cannot be optimized away.
Javagedes
force-pushed
the
personal/joeyvagedes/stop-optimize
branch
from
45a79d0 to
ce7a11d
Compare
Javagedes
changed the title
set_hob_list in debug_assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The compiler, on release builds, is removing the
set_hob_listcall due to being wrapped in a debug_assert. This results in in the hob list not being set, and us failing to get the hob list later. Due to lack to tests down the main setup code path, this was missed.This commit wraps the code in an assert instead and changes the interface.
REF: OpenDevicePartnership/patina-qemu#86
How This Was Tested
Boot to shell Q35 RELEASE
Integration Instructions
N/A