patina_dxe_core/fv: Fix test_fv_functionality() panic [Rebase & FF]
#1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
makubacki
force-pushed
the
fix_fv_zero_buf_test
branch
from
6c53ac4 to
9fb2aff
Compare
makubacki
changed the title
test_fv_functionality() panictest_fv_functionality() panic [Rebase & FF]
Collaborator
Javagedes
approved these changes
Dec 1, 2025
os-d
approved these changes
Dec 1, 2025
Contributor
os-d
left a comment
os-d
left a comment
There was a problem hiding this comment.
nit: The first commit message says it isn't going to follow the C behavior because it is unintuitive but then the second commit adds that behavior. May be worth amending the commit message.
Collaborator
Author
That reflects my decision process :). I decided to just get it to match to prevent dealing with some subtle difference in the future. I'll update the commit message. |
Fixes OpenDevicePartnership#1127 Code is currently commented out in `test_fv_functionality()` that calls `fv_read_file()` with a non-null buffer and buffer size of zero. This change updates `fv_read_file()` to follow the same behavior as the C DXE Core `FvReadFile()` function in FwVolRead.c that will return `BUFFER_TOO_SMALL` in this scenario. Another difference in behavior is that if the caller provides a non-null buffer but a buffer size less than the file content size, the C implementation will truncate the copy size to the size provided and perform the copy with that size. That change is made in a separate commit. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Matches the C implementation more closely by performing truncated copies when the provided buffer is too small. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
fix_fv_zero_buf_test
branch
from
634b6c3 to
7264ce3
Compare
joschock
reviewed
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1127
Code is currently commented out in
test_fv_functionality()that callsfv_read_file()with a non-null buffer and buffer size of zero.This change updates
fv_read_file()to follow the same behavior as the C DXE CoreFvReadFile()function in FwVolRead.c that will returnBUFFER_TOO_SMALLin this scenario.Another difference in behavior is that if the caller provides a non-null buffer but a buffer size less than the file content size, the C implementation will truncate the copy size to the size provided and perform the copy with that size. To prevent further discrepancies between caller expectations, that change is made in a second commit.
patina_dxe_core: Truncate copies in fv_read_file()
Matches the C implementation more closely by performing truncated copies
when the provided buffer is too small.
How This Was Tested
cargo make allIntegration Instructions