[REBASE&FF] Log bad components rather than panic #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Javagedes
force-pushed
the
personal/joeyvagedes/name-cow
branch
from
3f4ef4b to
2ef7e59
Compare
os-d
approved these changes
Dec 4, 2025
makubacki
approved these changes
Dec 4, 2025
This commit updates the Component state use Cow<'static, str> rather than directly a &'static str for component state (including the name and param error message"). This greatly improves the API available to us when working with these fields, while ensuring we only allocate a new instance of the string if we absolutely have to. As a side note, no allocation is made if creatining a Cow from an already static string, so there is no negative impact to this change.
This commit updates the Param trait's `init_state` method to return an result, where the error is a string explaining why the parameter could not be initialized. This error is ultimetly bubbled up to the to the component where the component_dispatcher will place the component in a separate list of components that failed initialization. The component is eventually logged with the reasoning why it failed to initialize.
Javagedes
force-pushed
the
personal/joeyvagedes/name-cow
branch
from
2ef7e59 to
e2ba725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the logic of component initialization to track a component that failed to initialize, and log it towards the end of boot, rather than panic on debug builds or possibly have UB on release builds.
Example output:
Note: While tests still need to be written, this is ready for review.
How This Was Tested
Integration Instructions
N/A