Add compile-time validation for Storage parameter conflicts #1158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
approved these changes
Dec 4, 2025
os-d
approved these changes
Dec 4, 2025
Implement validation rules for component `Storage`` parameters that follow normal Rust borrowing semantics: - Allow multiple `&Storage` parameters (multiple immutable references) - Allow a single `&mut Storage` parameter (exclusive mutable reference) - Prevent mixing `&Storage` with `&mut Storage` - Prevent duplicate `&mut Storage parameters` Adds macro unit tests and UI compilation failure message tests. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
add_component_storage_validation_check
branch
from
8841a27 to
9721861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement validation rules for component `Storage`` parameters that follow normal Rust borrowing semantics:
&Storageparameters (multiple immutable references)&mut Storageparameter (exclusive mutable reference)&Storagewith&mut Storage&mut StorageparametersAdds macro unit tests and UI compilation failure message tests.
Note: This was not clearly handled in the past (since component inception). An error would have been thrown but it would have misrepresented the problem to a conflicting
ConfigMut<T>instead of the real issue which is a conflicting&mut Storageparameter.How This Was Tested
cargo make allIntegration Instructions