Skip to content

Conversation

@joschock
Copy link
Contributor

@joschock joschock commented Dec 12, 2025

Description

This change switches the METADATA global static to use RwLock instead of AtomicPtr and adds some comments and tests to the module.

Closes #1187

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Confirmed Patina debugger operation on x86_64 QEMU. Confirmed that !monitor system_table_ptr and !monitor mod list work as expected.

Integration Instructions

N/A

@joschock joschock requested review from makubacki and os-d and removed request for os-d December 12, 2025 01:38
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 97.18310% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e_core/src/config_tables/debug_image_info_table.rs 97.18% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests!

@joschock joschock force-pushed the config_tables_no_atomic branch from 25d1bc4 to dc4fc4f Compare December 12, 2025 05:42
@joschock joschock force-pushed the config_tables_no_atomic branch from dc4fc4f to 2ac26be Compare December 12, 2025 18:39
@joschock joschock requested a review from cfernald December 12, 2025 19:39
@joschock joschock enabled auto-merge (squash) December 12, 2025 19:39
@joschock joschock merged commit f72da19 into OpenDevicePartnership:main Dec 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Evaluate removal of atomics in debug_image_info_table module

3 participants