Skip to content

Conversation

@Javagedes
Copy link
Collaborator

@Javagedes Javagedes commented Dec 15, 2025

Description

This commit does two things:

  1. Adds support for multiple event triggers
  2. Improves the ability to test macros by moving the feature flag conditional to a layer above, so we can consistently test the macro functionality, regardless of feature flags set.
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

CI

Integration Instructions

patina tests can now be annotated with multiple triggers:

#[patina_test]
#[on(timer = 1000000)]
#[on(event = patina::guids::EVENT_GROUP_END_OF_DXE)]
fn multi_triggered_test_case() -> Result {
  todo!()
}

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Dec 15, 2025
@Javagedes Javagedes requested a review from os-d December 15, 2025 19:36
@github-actions github-actions bot added the impact:testing Affects testing label Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sdk/patina_macro/src/test_macro.rs 87.50% 2 Missing ⚠️
sdk/patina/src/test.rs 94.12% 1 Missing ⚠️
sdk/patina_macro/src/lib.rs 66.67% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

This commit does two things:

1. Adds support for multiple event triggers
2. Improves the ability to test macros by moving the feature flag
   conditional to a layer above, so we can consistently test the macro
   functionality, regardless of feature flags set.
@Javagedes Javagedes force-pushed the personal/joeyvagedes/patina-test-multiple-event-triggers branch from 882c4fe to 92a536f Compare December 15, 2025 21:12
@Javagedes Javagedes merged commit d100f57 into OpenDevicePartnership:main Dec 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact impact:testing Affects testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants