Skip to content

[RFC - FCP]: Reorganize Device Path Libraries#1269

Merged
berlin-with0ut-return merged 12 commits intoOpenDevicePartnership:mainfrom
berlin-with0ut-return:device_path
Feb 13, 2026
Merged

[RFC - FCP]: Reorganize Device Path Libraries#1269
berlin-with0ut-return merged 12 commits intoOpenDevicePartnership:mainfrom
berlin-with0ut-return:device_path

Conversation

@berlin-with0ut-return
Copy link
Contributor

Description

See RFC for more details. Addresses #1148 by consolidating and reorganizing Device Path functionality.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A.

Integration Instructions

N/A.

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation labels Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an RFC describing a plan to consolidate and reorganize all Device Path Protocol functionality into a unified device_path module within the Patina SDK. It focuses on clarifying where Device Path types and parsing logic should live and proposes improved node-construction patterns to centralize header initialization.

Changes:

  • Introduces RFC 0024 outlining consolidation of Device Path structs and parsing into sdk/patina::device_path.
  • Documents current fragmentation of Device Path-related crates and the intended dependency direction (e.g., replacing patina_internal_device_path usage with the SDK).
  • Provides a high-level Rust code design, including example module layout and a more ergonomic MediaFwVolDevicePath constructor pattern.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@makubacki
Copy link
Collaborator

@berlin-with0ut-return, can you please specify the RFC state in the PR description? Right now, it should be "draft" since it hasn't gone to "FCP" yet.

@berlin-with0ut-return berlin-with0ut-return changed the title RFC: Reorganize Device Path Libraries [RFC - draft]: Reorganize Device Path Libraries Feb 3, 2026
@berlin-with0ut-return berlin-with0ut-return changed the title [RFC - draft]: Reorganize Device Path Libraries [RFC - DRAFT]: Reorganize Device Path Libraries Feb 3, 2026
Copy link
Collaborator

@makubacki makubacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal to move device path related content under a single module in the patina sdk crate sounds good. If you run into any conflicts or opens arise while merging the content, it'd be good to discuss further here.

@berlin-with0ut-return berlin-with0ut-return changed the title [RFC - DRAFT]: Reorganize Device Path Libraries [RFC - FCP]: Reorganize Device Path Libraries Feb 4, 2026
@berlin-with0ut-return berlin-with0ut-return merged commit a7e1d81 into OpenDevicePartnership:main Feb 13, 2026
8 checks passed
berlin-with0ut-return added a commit that referenced this pull request Feb 13, 2026
## Description
Move device path modules into a single unified location (in sdk). Add
constructors to manage custom Device Path node types. This PR does not
include any functional changes.

This is based on design described in
#1269.
Resolves #1148.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested
Passes all existing tests.

## Integration Instructions
N/A.

---------

Co-authored-by: Sherry Fan <sherryfan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants