[RFC - FCP]: Reorganize Device Path Libraries#1269
[RFC - FCP]: Reorganize Device Path Libraries#1269berlin-with0ut-return merged 12 commits intoOpenDevicePartnership:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an RFC describing a plan to consolidate and reorganize all Device Path Protocol functionality into a unified device_path module within the Patina SDK. It focuses on clarifying where Device Path types and parsing logic should live and proposes improved node-construction patterns to centralize header initialization.
Changes:
- Introduces RFC 0024 outlining consolidation of Device Path structs and parsing into
sdk/patina::device_path. - Documents current fragmentation of Device Path-related crates and the intended dependency direction (e.g., replacing
patina_internal_device_pathusage with the SDK). - Provides a high-level Rust code design, including example module layout and a more ergonomic
MediaFwVolDevicePathconstructor pattern.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@berlin-with0ut-return, can you please specify the RFC state in the PR description? Right now, it should be "draft" since it hasn't gone to "FCP" yet. |
makubacki
left a comment
There was a problem hiding this comment.
The proposal to move device path related content under a single module in the patina sdk crate sounds good. If you run into any conflicts or opens arise while merging the content, it'd be good to discuss further here.
75dda20 to
4edcf15
Compare
ff14179 to
1a62b9e
Compare
a7e1d81
into
OpenDevicePartnership:main
## Description Move device path modules into a single unified location (in sdk). Add constructors to manage custom Device Path node types. This PR does not include any functional changes. This is based on design described in #1269. Resolves #1148. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Passes all existing tests. ## Integration Instructions N/A. --------- Co-authored-by: Sherry Fan <sherryfan@microsoft.com>
Description
See RFC for more details. Addresses #1148 by consolidating and reorganizing Device Path functionality.
How This Was Tested
N/A.
Integration Instructions
N/A.