dxe_core: Ensure Stack Guard Is Enabled When Init'ing Paging#1277
Merged
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom Feb 9, 2026
Merged
dxe_core: Ensure Stack Guard Is Enabled When Init'ing Paging#1277makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
makubacki merged 1 commit intoOpenDevicePartnership:mainfrom
Conversation
os-d
requested review from
cfernald,
joschock,
kuqin12,
makubacki and
srilathasridharan
joschock
approved these changes
Feb 3, 2026
makubacki
approved these changes
Feb 3, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
cfernald
approved these changes
Feb 5, 2026
os-d
force-pushed
the
stackguard
branch
2 times, most recently
from
5ea9b18 to
bf2066a
Compare
Currently, the init_paging routine doesn't know about the stack guard, which is set up earlier. It ends up wiping this. This commit moves the stack guard setup to init_paging to take it into account. It was considered to make this more generic, to take already set attributes, but the number of cases where we expect access attributes to be set should just be the null page and stack guard page, so handle them explicitly. Signed-off-by: Oliver Smith-Denny <osde@microsoft.com>
Contributor
Author
|
@makubacki can we force merge this? It’s actually more code coverage than it was before, but I only got it to 78% patch coverage. I could force the attribute setting to fail on the stack hob, but that’s not useful to test, it’s just a panic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the init_paging routine doesn't know about the stack guard, which is set up earlier. It ends up wiping this.
This commit moves the stack guard setup to init_paging to take it into account.
It was considered to make this more generic, to take already set attributes, but the number of cases where we expect access attributes to be set should just be the null page and stack guard page, so handle them explicitly.
How This Was Tested
Tested on Q35 and SBSA with the memory protections test failing and then succeeding.
Integration Instructions
N/A.