Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cartopy<0.20 requirement #733

Merged
merged 9 commits into from
Mar 14, 2022
Merged

remove cartopy<0.20 requirement #733

merged 9 commits into from
Mar 14, 2022

Conversation

gauteh
Copy link
Member

@gauteh gauteh commented Oct 15, 2021

No description provided.

@gauteh
Copy link
Member Author

gauteh commented Oct 15, 2021

@knutfrode : do you remember why we had this in the first place?

@knutfrode
Copy link
Collaborator

No, it seems like you added this 24 days ago, in relation to #708:

ee4db8e#diff-9efd195f4e9bfb79ccd456a1d8370fafcc4bcb0b00ea3799222667d2ae818533

@knutfrode
Copy link
Collaborator

But we do get this now:

pyproj.exceptions.ProjError: Error creating Transformer from CRS.: (Internal Proj Error: proj_create_operations: Source and target ellipsoid do not belong to the same celestial body)

@gauteh
Copy link
Member Author

gauteh commented Oct 15, 2021

hm yes, seems like tests fail and we need to make some changes in plotting to work with new cartopy.

@knutfrode
Copy link
Collaborator

Maybe we can get away with fixes like this:

x, max_y = self.transform_point(lon, lat, PlateCarree())
x, max_y = self.transform_point(lon, lat, PlateCarree(globe=self.globe))

SciTools/cartopy#1252

@gauteh gauteh merged commit 4a03660 into OpenDrift:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants