Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish-docker.yml #123

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Conversation

Jeongyong-park
Copy link
Contributor

Add docker tags by dates
#110

add docker tags
@pierotofy
Copy link
Member

pierotofy commented Nov 4, 2024

Thanks for the PR @Jeongyong-park !
I don't know if we should keep tags for each push to master (e.g. by date like the proposed changes).

It would be nice to have per-version tags though (can this PR be modified to have that instead?)

@Jeongyong-park
Copy link
Contributor Author

Thanks for the PR @Jeongyong-park ! I don't know if we should keep tags for each push to master (e.g. by date like the proposed changes).

It would be nice to have per-version tags though (can this PR be modified to have that instead?)

Thank you for your kindly commented @pierotofy !!

I changed the code with your advice and some github action plugins migrated with latest versions.

However, I don't have Secrets so I haven't tested it properly, but I made it according to the documentation so it should work.

@Jeongyong-park Jeongyong-park marked this pull request as draft November 4, 2024 04:35
@Jeongyong-park
Copy link
Contributor Author

Tested and fixed.

I made my own public repo and tested with Github Actions.
I will delete the repo in dockerhub after merge.

https://github.com/Jeongyong-park/ClusterODM/actions/runs/11658165416

https://hub.docker.com/repository/docker/kladess/clusterodm/tags

@Jeongyong-park Jeongyong-park marked this pull request as ready for review November 4, 2024 04:46
@pierotofy
Copy link
Member

Thanks @Jeongyong-park ! Looks great. 🙏

@pierotofy pierotofy merged commit bb4676c into OpenDroneMap:master Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants