-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tiler zoom level configurable #1705
Conversation
This looks great! Do you think you would be able to read the GSD for orthophoto/de and set the min-zoom to that? Max I can't think of a reason to change... I'm just musing if parameterless would be possible and meet your usecase? I think many folks would love this! |
Dynamic min-zoom level, depending on the GSD, sounds interesting. I'll take a look into making the min-zoom dynamic instead of a parameter. Parameterless looks like the better choice. |
Thank you so much! I am sorry to put more work on your shoulders, but we struggle a bit with folks keeping track of all the parameters we already have, so when we can meet a need without adding one... It's a lot nicer for folks to work with. I'm excited to see what you make! |
Instead of hardcoding a value, calculate the maximum zoomlevel in which there is still an increase in detail. By using the configured orthophoto resolution or GSD. The higher the latitude, the higher the resolution will be of the tile. Resulting in a chance of generating useless tiles, as there is no compensation for this. At the moment it'll use the worst-case resolution from the equator. Zoom level calulation from: https://wiki.openstreetmap.org/wiki/Zoom_levels
I've added calculations depending on the GSD. However in the splitmerge I could not find the GSD, so there I used the configured orthophoto-resolution argument. |
So, so cool! You should have a review by someone who can assess the code better than I shortly. Thanks so much again for this amazing feature! You're going to make so many folks so happy. |
Thanks for the PR @MertenF ! It looks like a useful addition. I think we still need to enforce a more conservative maximum zoom level. I don't think we should go higher than |
Each extra zoom level means that the amount of tiles goes times 5. So I guess it's not a big surprise that those higher levels need a lot more computation time. With that in mind, the limit that I've set ( Level What do you think? |
I think 23 is reasonable. 👍 |
Looks great, thanks @MertenF ! |
The zoom levels for generating 2d tiles is fixed to 5-21.
By adding following 2 options, it will be possible to configure the zoom levels.
--tiles-min-zoom
--tile-max-zoom
I have not yet tested these changes. Looking for feedback.