-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding TIFFTAG_* to .tif outputs #1797
Conversation
Thanks @stephenwinn16, note we should probably set the tags in/around https://github.com/OpenDroneMap/ODM/blob/master/stages/odm_postprocess.py#L38 similarly to how we set GCPs metadata. You could find the precomputed start/end dates in Yes version is stored in |
This reverts commit 4734d88.
Reverted previous changes and moved all steps into the ODMPostProcess step.
Thanks @pierotofy for the comments. I've moved the lines into the Do you see any other useful information to include with the TIFFTAG fields? |
Thanks @stephenwinn16, I've made some changes to simplify the logic and avoid reading files from disk, I realized we already had a function to read the ODM version and that it was probably faster to read the UTC time from the photos object which is already in memory, I'll run some more tests and merge this shortly. 🙏 |
Great, more efficient and much cleaner, thank you @pierotofy ! |
Following up on #1793, I've added steps to the orthophoto and DSM/DTM generation to be able to include TIFFTAG information. In the current commit, I've hardcoded a datetime for testing purposes. I would like this to be replaced by a mean capture time based on the input image metadata (such as the "Capture Start" and "Capture End" that appear e.g. in the PDF report). Would anyone be able to point me to a good place to pull them from during the processing pipeline?
Additionally, is the ODM version stored somewhere during the processing pipeline? Or should it always be read from the
VERSION
file as inrun.py
?