-
-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update app/boot.py #1423
update app/boot.py #1423
Conversation
This requires some thought, as in absence of proper metadata the radiometric calibration doesn't work, but skipping the global seam leveling will cause seam visibility. |
Ugh... Multi-spectral is fun. What approach sounds reasonable? An allow-list of known working sensors we pass it for? |
I don't know what folks expect on the drone side, but on the satellite multispectral side, showing seams is an acceptable alternative when adequate reflectance corrections aren't available. |
It seems that the sUAS expectation is that it "Just Works ™" |
I've received complaints when seams were present. |
If returns count as complaints, it is non-zero for this... |
Complaints that we weren't blending by default or complaints that there was a way to bypass blending? The latter would be a strange compliant, but I suppose we've seen stranger. I'm surprised academic users haven't complained that we are blending without a method for bypassing. There should always be a way to bypass blending for scientific use cases. But anyway, I have no skin in this game at this time, so 🤷. |
Complaints that only our software has seams and no others do 🤷 I absolutely agree we should keep a way to not blend, but it appears more of our users expect it. |
Random Postscript: super interested in the separation of illumination from surface color we see in neural applications. I would love to see incorporation of proper brdf (or modern equivalent) into in quantitative drone imaging. No idea if anyone is working in this space, and I currently have no use cases myself at this time. |
Thanks for the manual calculation of BRDF PTGISD. I had buried that 🙃 |
I'll close this, as we should continue blending by default. |
Add flag
--texturing-skip-global-seam-leveling
since I've seen a number of multispectral datasets processed without this and folks thinking our processing is broken due to getting out of range values.