Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imperial units support, improvements, fixes, plugins API expansion #1496

Merged
merged 31 commits into from
May 13, 2024

Conversation

pierotofy
Copy link
Member

Various improvements and fixes.

@pierotofy pierotofy changed the title Miscellaneous improvements, fixes, plugins API expansion Imperial units support, improvements, fixes, plugins API expansion May 9, 2024
@pierotofy
Copy link
Member Author

Well, I started adding support for imperial units (both international and US), because it's overdue.

@pierotofy
Copy link
Member Author

#1065

@smathermather
Copy link
Contributor

The Mars Climate Orbiter will thank you.

@pierotofy
Copy link
Member Author

pierotofy commented May 11, 2024

Also ~25% speed-up in rendering DSM/DTM tiles (when shaded).

@pierotofy pierotofy marked this pull request as ready for review May 13, 2024 18:36
@pierotofy
Copy link
Member Author

pierotofy commented May 13, 2024

This should be good to go. There's some improvements that could be done on the measurement plugin, such as the ability to update existing measurements when switching units, currently one needs to create new measurements to use a new unit system, but these can be addressed in the future...

Potree also has no support for US imperial units, so there's not exactly a 1-to-1 relation between 3D view and map view if the user chooses to use US imperial units (which they shouldn't, it's 2024).

@smathermather
Copy link
Contributor

Is it too late to ask for a couple more imperial units, specifically the following length and area measures?:

Area: gallons per fathom (GPF)

Length: hogsheads per rood (HPR)

ht @ivangayton

@pierotofy
Copy link
Member Author

pierotofy commented May 13, 2024

Shouldn't be a problem, one can just modify Units.js and UnitSelector.jsx.

@pierotofy pierotofy merged commit 32ba4ed into OpenDroneMap:master May 13, 2024
1 check passed
@smathermather
Copy link
Contributor

Shouldn't be a problem, one can just modify Units.js and UnitSelector.jsx.

Super tempted to do that on crankyserver...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants