Improved Mech movement #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IceReaper
reviewed
Feb 24, 2023
|
After changes suggested in the comments the PR will be approved. |
michaeldgg2
requested changes
Feb 24, 2023
IceReaper
reviewed
Feb 25, 2023
There was a problem hiding this comment.
Overall a good and awesome PR :) While my proposed changes look like much, its actualy not much, but the impact of those few things spreads through much of the file, sorry for that :/
Anyway, this is again just a suggestion. @michaeldgg2 has to decide ;)
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
michal-mad
force-pushed
the
mech-movement
branch
from
d0ba7bf to
39af20e
Compare
IceReaper
reviewed
Mar 1, 2023
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
OpenRA.Mods.OpenE2140/Traits/Rendering/WithMovingSpriteTurret.cs
Outdated
Show resolved
Hide resolved
michal-mad
force-pushed
the
mech-movement
branch
from
2b3a8bc to
a71b363
Compare
Adjusted Tiger Assault legs movement speed Refactoring according to PR comments Removed rule suppression; Moved sim params to info class; Replaced floats with ints; Brought back lost csproj file Unified overlooked field style Merge branch 'mech-movement' of https://github.com/michal-mad/OpenE2140 into mech-movement Update with a comment
michal-mad
force-pushed
the
mech-movement
branch
from
0dee6d8 to
66dc335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is regarding: #30
This PR introduces upper body movement for mech while walking. It should also better sync with moving sound and legs motion relative to travelled distance. Little more tweaks on the matter may be made according to comments.
Orig behavior:
Proposed behavior:
