Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEMS Backports 2024-12-01 #2894

Merged
merged 9 commits into from
Nov 30, 2024
Merged

FEMS Backports 2024-12-01 #2894

merged 9 commits into from
Nov 30, 2024

Conversation

sfeilmeier
Copy link
Contributor

@sfeilmeier sfeilmeier commented Nov 30, 2024

Edge

  • Carlo Gavazzi Meter: fix scaling and extended DummyModbusBridge testing
    • Fixes scaling of Carlo Gavazzi meter
    • Currently the current is way too high (x100)
    • Added JUnit tests
  • BMW Battery: backports of improvements.
  • Meter : Implementation of Simens Sicam meter
  • Time-of-Use-Tariff & EnergyScheduler V2 improvements
    • Allow managed consumption in EnergyFlow
    • Fix postprocessing
    • Move version and risk-level to EnergyScheduler
    • Implement Codec for Jenetics
    • Prepare attachments to OneSimulationContext
    • Optimizer: improve thread interrupt
    • Rework InitialPopulation to use int[][] instead of Chromosome
    • Fix immediate reaction to configuration change events
    • Prepare integration of EVCS

UI

  • Use dataService subcribe for energymonitor channels
    • Replace energymonitor currentData subscribe with dataService subscribe
  • Add eslint rule for file naming conventions
    • Adding eslint rule for kebab-case file naming convention, turned to off regarding too many changes needed
  • Adjust live reload behavior
    • Adjust pull to refresh, to be more appearant and give user feedback if live data is still up to date -> didnt update in 20 seconds
    • make banner sticky
  • AppCenter: added uninstallation confirm button
    • added confirmation button when deinstalling an app

Co-authored-by: Fabian Brandtner 10850256+fabian94533@users.noreply.github.com
Co-authored-by: Pooran Chandrashekaraiah 46567310+pooran-c@users.noreply.github.com
Co-authored-by: Lukas Rieger 73471197+lukasrgr@users.noreply.github.com
Co-authored-by: Stefan Feilmeier 3515268+sfeilmeier@users.noreply.github.com
Co-authored-by: Michael Grill 59126309+michaelgrill@users.noreply.github.com

sfeilmeier and others added 9 commits November 30, 2024 23:10
- Fixes scaling of Carlo Gavazzi meter
- Currently the current is way too high (x100)
- Added JUnit tests

Reviewed-by: Sebastian Asen <47855186+sebastianasen@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Fabian Brandtner <10850256+fabian94533@users.noreply.github.com>
Co-committed-by: Fabian Brandtner <10850256+fabian94533@users.noreply.github.com>
Backports of  BMW Battery improvements.

Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
Co-committed-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
- Replace energymonitor `currentData` subscribe with dataService subscribe

Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Adding eslint rule for `kebab-case` file naming convention, turned to `off` regarding too many changes needed

Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Co-authored-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
Co-committed-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
- Allow managed consumption in EnergyFlow
- Fix postprocessing
- Move version and risk-level to EnergyScheduler
- Implement Codec for Jenetics
- Prepare attachments to OneSimulationContext
- Optimizer: improve thread interrupt
- Rework InitialPopulation to use int[][] instead of Chromosome
- Fix immediate reaction to configuration change events
- Prepare integration of EVCS

Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com>
- Adjust pull to refresh, to be more appearant and give user feedback if live data is still up to date -> didnt update in `20` seconds
- make banner sticky

Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
- added confirmation button when deinstalling an app

Reviewed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com>
Co-authored-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com>
Co-committed-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com>
@sfeilmeier sfeilmeier merged commit 923265e into develop Nov 30, 2024
2 checks passed
@sfeilmeier sfeilmeier deleted the feature/fems-backports branch November 30, 2024 22:46
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 385 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2894      +/-   ##
=============================================
+ Coverage      57.31%   57.32%   +0.01%     
- Complexity      9162     9232      +70     
=============================================
  Files           2178     2188      +10     
  Lines          92883    93247     +364     
  Branches        6884     6913      +29     
=============================================
+ Hits           53231    53447     +216     
- Misses         37703    37838     +135     
- Partials        1949     1962      +13     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant