-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEMS Backports 2024-12-01 #2894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes scaling of Carlo Gavazzi meter - Currently the current is way too high (x100) - Added JUnit tests Reviewed-by: Sebastian Asen <47855186+sebastianasen@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Fabian Brandtner <10850256+fabian94533@users.noreply.github.com> Co-committed-by: Fabian Brandtner <10850256+fabian94533@users.noreply.github.com>
Backports of BMW Battery improvements. Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com> Co-committed-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
- Replace energymonitor `currentData` subscribe with dataService subscribe Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com> Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Adding eslint rule for `kebab-case` file naming convention, turned to `off` regarding too many changes needed Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com> Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
Co-authored-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com> Co-committed-by: Pooran Chandrashekaraiah <46567310+pooran-c@users.noreply.github.com>
- Allow managed consumption in EnergyFlow - Fix postprocessing - Move version and risk-level to EnergyScheduler - Implement Codec for Jenetics - Prepare attachments to OneSimulationContext - Optimizer: improve thread interrupt - Rework InitialPopulation to use int[][] instead of Chromosome - Fix immediate reaction to configuration change events - Prepare integration of EVCS Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com>
- Adjust pull to refresh, to be more appearant and give user feedback if live data is still up to date -> didnt update in `20` seconds - make banner sticky Reviewed-by: Sagar Venu <32655208+venu-sagar@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com> Co-committed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com>
- added confirmation button when deinstalling an app Reviewed-by: Lukas Rieger <73471197+lukasrgr@users.noreply.github.com> Reviewed-by: Stefan Feilmeier <3515268+sfeilmeier@users.noreply.github.com> Co-authored-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com> Co-committed-by: Michael Grill <59126309+michaelgrill@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2894 +/- ##
=============================================
+ Coverage 57.31% 57.32% +0.01%
- Complexity 9162 9232 +70
=============================================
Files 2178 2188 +10
Lines 92883 93247 +364
Branches 6884 6913 +29
=============================================
+ Hits 53231 53447 +216
- Misses 37703 37838 +135
- Partials 1949 1962 +13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edge
UI
currentData
subscribe with dataService subscribekebab-case
file naming convention, turned tooff
regarding too many changes needed20
secondsCo-authored-by: Fabian Brandtner 10850256+fabian94533@users.noreply.github.com
Co-authored-by: Pooran Chandrashekaraiah 46567310+pooran-c@users.noreply.github.com
Co-authored-by: Lukas Rieger 73471197+lukasrgr@users.noreply.github.com
Co-authored-by: Stefan Feilmeier 3515268+sfeilmeier@users.noreply.github.com
Co-authored-by: Michael Grill 59126309+michaelgrill@users.noreply.github.com