Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Style of Level ion-select after Upgrade to Angular 19 #2933

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sn0w3y
Copy link
Contributor

@Sn0w3y Sn0w3y commented Dec 19, 2024

Description:

This PR addresses the styling issues related to the "Level" ion-select component after the upgrade to Angular 19. The update resolves issues with the component's appearance, ensuring it aligns with the expected UI standards.

Changes:

  • Corrected the configuration and attributes of the "Level" ion-select in systemlog.component.html.
    • Removed duplicate ion-select tags and conflicting attributes.
    • Ensured the proper fill, label, and interface attributes are applied to maintain consistent styling.
    • Fixed label positioning and interfaceOptions for the custom styling of the popover.

Before:

image

AfteR:

image

Reason for Change:

  • Following the upgrade to Angular 19, some ion-select components, particularly the "Level" selection dropdown, were displaying incorrectly due to conflicting properties and misapplied styles.
  • This fix ensures that the component’s appearance is correct and consistent, addressing issues with the dropdown's label and the popover interface.

Impact:

  • The "Level" ion-select now displays correctly with the appropriate styling and functionality.
  • Improves UI consistency and ensures the filter options appear as intended.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2933      +/-   ##
=============================================
+ Coverage      56.63%   56.63%   +0.01%     
- Complexity      9513     9514       +1     
=============================================
  Files           2253     2253              
  Lines          96074    96074              
  Branches        7095     7095              
=============================================
+ Hits           54401    54402       +1     
+ Misses         39666    39662       -4     
- Partials        2007     2010       +3     

@sfeilmeier sfeilmeier requested a review from lukasrgr December 19, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant